Add error label to workflow run (#299)

* add error label to workflow rung * add migration * fix lint migration * if error is none empty string
chanzuckerberg · Apr 19, 2024 · a34b728 · a34b728
1 parent e2cc6f1
commit a34b728
Show file tree

Hide file tree

Showing 14 changed files with 138 additions and 3 deletions.
diff --git a/workflows/api/helpers/workflow_run.py b/workflows/api/helpers/workflow_run.py
diff --git a/workflows/api/loader/loader.py b/workflows/api/loader/loader.py
@@ -127,7 +127,8 @@ async def handle_message(event: WorkflowStatusMessage) -> None:
                 if workflow_run:
                     workflow_run.status = WorkflowRunStatus.FAILED
                     if event.error:
-                        workflow_run.error_message = event.error
+                        workflow_run.error_label = event.error
+                        workflow_run.error_message = event.error_message or ""
                     await self.session.commit()
 
         return handle_message

diff --git a/workflows/api/schema.graphql b/workflows/api/schema.graphql
diff --git a/workflows/api/schema.json b/workflows/api/schema.json
@@ -728,6 +728,15 @@
                 "ofType": null
               }
             },
+            {
+              "args": [],
+              "name": "errorLabel",
+              "type": {
+                "kind": "SCALAR",
+                "name": "String",
+                "ofType": null
+              }
+            },
             {
               "args": [],
               "name": "errorMessage",
@@ -2722,6 +2731,15 @@
                 "ofType": null
               }
             },
+            {
+              "defaultValue": null,
+              "name": "errorLabel",
+              "type": {
+                "kind": "INPUT_OBJECT",
+                "name": "StrComparators",
+                "ofType": null
+              }
+            },
             {
               "defaultValue": null,
               "name": "errorMessage",
@@ -4158,6 +4176,15 @@
                 "ofType": null
               }
             },
+            {
+              "defaultValue": null,
+              "name": "errorLabel",
+              "type": {
+                "kind": "ENUM",
+                "name": "orderBy",
+                "ofType": null
+              }
+            },
             {
               "defaultValue": null,
               "name": "errorMessage",
@@ -4476,6 +4503,15 @@
                 "ofType": null
               }
             },
+            {
+              "args": [],
+              "name": "errorLabel",
+              "type": {
+                "kind": "SCALAR",
+                "name": "String",
+                "ofType": null
+              }
+            },
             {
               "args": [],
               "name": "errorMessage",
@@ -4612,6 +4648,15 @@
                 "ofType": null
               }
             },
+            {
+              "args": [],
+              "name": "errorLabel",
+              "type": {
+                "kind": "SCALAR",
+                "name": "String",
+                "ofType": null
+              }
+            },
             {
               "args": [],
               "name": "errorMessage",
@@ -4732,6 +4777,9 @@
             {
               "name": "status"
             },
+            {
+              "name": "errorLabel"
+            },
             {
               "name": "errorMessage"
             },
@@ -7207,6 +7255,15 @@
                 "ofType": null
               }
             },
+            {
+              "defaultValue": "null",
+              "name": "errorLabel",
+              "type": {
+                "kind": "SCALAR",
+                "name": "String",
+                "ofType": null
+              }
+            },
             {
               "defaultValue": "null",
               "name": "errorMessage",

diff --git a/workflows/api/types/workflow_run.py b/workflows/api/types/workflow_run.py
diff --git a/workflows/api/validators/workflow_run.py b/workflows/api/validators/workflow_run.py
diff --git a/workflows/cerbos/policies/workflow_run.yaml b/workflows/cerbos/policies/workflow_run.yaml
@@ -1,5 +1,5 @@
 # Auto-generated by running 'make codegen'. Do not edit.
-# Make changes to the template codegen/templates/cerbos/policies/class_name.yaml.j2 instead.
+# Make changes to the template template workflows_templates/cerbos/policies/workflow_run.yaml.j2 instead.
 # yaml-language-server: $schema=https://api.cerbos.dev/latest/cerbos/policy/v1/Policy.schema.json
 apiVersion: api.cerbos.dev/v1
 resourcePolicy:

diff --git a/workflows/cerbos/policies/workflow_run_entity_input.yaml b/workflows/cerbos/policies/workflow_run_entity_input.yaml
@@ -1,4 +1,5 @@
-# Make changes to the template codegen/templates/cerbos/policies/class_name.yaml.j2 instead.
+# Auto-generated by running 'make codegen'. Do not edit.
+# Make changes to the template workflows_templates/cerbos/policies/workflow_run_entity_input.yaml.j2 instead.
 # yaml-language-server: $schema=https://api.cerbos.dev/latest/cerbos/policy/v1/Policy.schema.json
 apiVersion: api.cerbos.dev/v1
 resourcePolicy:

diff --git a/workflows/cli/gql_schema.py b/workflows/cli/gql_schema.py