[CZID-8697] Codegen tests - part 1 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mics into raboukhalil/CZID-8697-codegen-tests
robertaboukhalil
changed the title
| # Make sure tests can get their own instances of the app. | ||
| def get_app() -> FastAPI: | ||
| def get_app(use_test_schema: bool = False) -> FastAPI: |
There was a problem hiding this comment.
Allow us to define whether to use the test schema or not
|
|
||
| import pytest | ||
| from api.conftest import GQLTestClient | ||
|
|
There was a problem hiding this comment.
An example of where tests on our real schema would go
| @@ -123,6 +125,9 @@ def api_generate(ctx: click.Context, schemafile: str, output_prefix: str) -> Non | |||
| view.imports_closure() | |||
| wrapped_view = ViewWrapper(view) | |||
|
|
|||
| for dir in DIR_CODEGEN: | |||
There was a problem hiding this comment.
The first time you run codegen, folders don't exist
| @@ -13,7 +13,7 @@ from api.types.{{ class.snake_name }} import {{ class.name }}, resolve_{{ class. | |||
| @strawberry.type | |||
| class Query: | |||
| # Allow queries by node ID | |||
| node: relay.Node = relay.node() | |||
| nodes: List[relay.Node] = relay.node() | |||
There was a problem hiding this comment.
Updating the relay query as per Strawberry docs to support an array of node IDs (will check with FE team what they're expected use case for this is)
| from fastapi import FastAPI | ||
| from api.conftest import GQLTestClient | ||
|
|
||
|
|
There was a problem hiding this comment.
Just want to be sure we're testing the right schema 🙂
jgadling
reviewed
Nov 16, 2023
…mics into raboukhalil/CZID-8697-codegen-tests # Conflicts: # .gitattributes
j-x-han
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of adding codegen tests