chore: CCIE-3986 use persist-credentials: false in checkout #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wontonst
force-pushed
the
rzheng/CCIE-3986
branch
from
ec45df8 to
f6932ba
Compare
wontonst
commented
Feb 4, 2025
| @@ -51,6 +51,7 @@ runs: | |||
| } | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| persist-credentials: true # creds used in Update Argus Manifest step | |||
There was a problem hiding this comment.
not sure if we just accept this risk or if we want to do something about this
in my experience, automation doesn't make commits against the repo. the name of the artifact is also not something baked into the repo that get constantly updated. it's usually an external system managing the mapping of git hash to docker img tag, and that system will also keep track of what's deployed in prd/staging. sounds like that should be all done in argus so I'm curious if that's something that's possible/something we've considered doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a manual inspection of the files but no guarantees that this won't break something.
If anyone knows of a place where we run privileged git commands other than update manifest, please let me know.
If this PR doesn't end up breaking anything I'll open PRs for other repos using the same approach.