Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for falsy mappings #727

Merged
merged 1 commit into from
Mar 2, 2025
Merged

check for falsy mappings #727

merged 1 commit into from
Mar 2, 2025

Conversation

ahvigil
Copy link
Contributor

@ahvigil ahvigil commented Feb 21, 2025

Motivation

Address the failure in #726 by checking for falsy Map values in the same way the branch above does for Arrays.

Approach

Just mirroring the handling of empty Arrays!

Checklist

  • Add appropriate test(s) to the automatic suite
  • Use make pretty to reformat the code with black
  • Use make check to statically check the code using Pyre and Pylint
  • Send PR from a dedicated branch without unrelated edits
  • Ensure compatibility with this project's MIT license

@ahvigil
Copy link
Contributor Author

ahvigil commented Feb 21, 2025

I checked this against the demo workflow in the linked issue to confirm this addresses the problem:

$ miniwdl run --no-cache demo.wdl
...
2025-02-21 15:02:51.319 wdl.w:demo done
{
  "dir": ".../20250221_150248_demo",
  "outputs": {
    "demo.echo.output_map": {}
  }
}

@mlin mlin merged commit 3ece03a into chanzuckerberg:main Mar 2, 2025
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants