Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedent task commands before eval/interpolation #734

Merged
merged 4 commits into from
Mar 16, 2025

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Mar 16, 2025

Unifies dedent logic with multi-line strings.

Introduces WDL.Expr.TaskCommand, a specialization of WDL.Expr.String that handles this and other command-specific evaluation logic.

Config option [task_runtime] old_command_dedent to restore old post-eval dedenting, just in case someone needs.

see: #674

@coveralls
Copy link

coveralls commented Mar 16, 2025

Pull Request Test Coverage Report for Build 13881540474

Details

  • 49 of 49 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.21%

Totals Coverage Status
Change from base Build 13840664927: 0.03%
Covered Lines: 7394
Relevant Lines: 7766

💛 - Coveralls

@mlin mlin marked this pull request as ready for review March 16, 2025 08:28
@mlin mlin merged commit 0707db8 into main Mar 16, 2025
12 checks passed
@mlin mlin deleted the mlin/dedent-command-before-eval branch March 16, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants