Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for mus musculus descendant organisms #1248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joyceyan
Copy link
Contributor

@joyceyan joyceyan commented Feb 4, 2025

Reason for Change

https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-curation/1243

Changes

  • updates schema definition to add support for mus musculus descendants
  • upon further inspection it appears as if the print output for ONTOLOGY_PARSER.get_term_descendants("NCBITaxon:10090", include_self=True) is simply term_descendants ['NCBITaxon:10090']
  • seems like there's maybe a bug in COG?

Testing

added unit tests which seem to fail

Notes for Reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant