fix: exclude specific ontology term id keys #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seve
reviewed
Jun 7, 2024
| @@ -15,8 +15,17 @@ export const unassignedCategoryLabel = "unassigned"; | |||
| /** Maximum number of cells a dataset can have in order to be included for display. */ | |||
| export const DATASET_MAX_CELL_COUNT = 2_000_000; | |||
|
|
|||
| /* Category name suffix used to determine if category name is ontology term id. */ | |||
| export const ONTOLOGY_KEY = "ontology_term_id"; | |||
| /* Explicit ontology term ids. */ | |||
There was a problem hiding this comment.
why do we want to make this explicit?
There was a problem hiding this comment.
yes - the feedback from Jason was that the general filter for ontology_term_id was too broad and we should exclude the ones on this list based on the schema definition
seve
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#950
added const: ONTOLOGY_TERM_ID_KEYS
removed: ONTOLOGY_KEY
revised: isCategoryNameOntologyKey, buildDatasetMetadataViews
also - moved
in_tissueto Standard Categories`