-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU support for sparse matrix multiplication with events #56
Draft
Routhleck
wants to merge
5
commits into
main
Choose a base branch
from
event-csr-gpu-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces GPU support for sparse matrix multiplication and vector multiplication operations using Pallas. It includes both forward and transposed operations, and it supports boolean, float, and float-as-event data types. Sequence diagram for GPU-based CSR matrix-vector multiplicationsequenceDiagram
participant Client
participant event_csrmv_p
participant GPU_Kernel
participant Memory
Client->>event_csrmv_p: Call with weights, indices, indptr, v
alt GPU backend
event_csrmv_p->>GPU_Kernel: Generate kernel with block_size
GPU_Kernel->>Memory: Atomic operations on output vector
loop For each block
GPU_Kernel->>GPU_Kernel: Process rows in block
GPU_Kernel->>Memory: Update results
end
Memory-->>Client: Return result vector
end
Class diagram for CSR matrix operationsclassDiagram
class event_csrmv_p {
+cpu_kernel_or_generator
+gpu_kernel_or_generator
+defjvp()
+def_transpose_rule()
}
class event_csrmm_p {
+cpu_kernel_or_generator
+gpu_kernel_or_generator
+def_batching_rule()
}
class Kernel {
+block_size: int
+shape: Shape
+float_as_event: bool
+weight_info: ShapeDtypeStruct
+indices_info: ShapeDtypeStruct
+spike_info: ShapeDtypeStruct
+transpose: bool
}
event_csrmv_p ..> Kernel
event_csrmm_p ..> Kernel
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
New Features: