[cmd] Check services are up when the platform starts #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
reviewed
Feb 26, 2025
There was a problem hiding this comment.
I see several problems with this solution:
- The component could get stuck waiting for any of the required services to be available. It's better to limit the tries.
- Each iteration waits the same time to check if the service is available. Normally is better to use a exponential backoff approach to avoid collisions.
- OpenSearch is only available if the archivists is configured for that. Right now we don't have any other backend to store the data but there will be. I think this should be addressed now.
jjmerchante
force-pushed
the
check-services
branch
2 times, most recently
from
8eeced4 to
6ff6b40
Compare
Server, producer and consumers wait until the required services are up before starting. If the services are not available after 10 retries, the service fails to start. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
check-services
branch
2 times, most recently
from
dbd67e9 to
5be1f8c
Compare
|
I updated the PR to fail when the services are not ready |
jjmerchante
force-pushed
the
check-services
branch
from
5be1f8c to
95f8edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server, producer and consumers wait until the required services are up before starting.
Fixes chaoss/grimoirelab#740