[datasources] Organize repositories into projects #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Jun 19, 2025
There was a problem hiding this comment.
Datasets should be only for internal representation. Users shouldn't have to deal with that. I think it's better if the have access to the repositories with endpoint such as:
/ecosystems/<eco>/projects/<project>/repos/
/ecosystems/<eco>/projects/<project>/repos/<id>
/ecosystems/<eco>/projects/<project>/repos/<id>/categories/<category>
Where <id> should be either a or numerical id build from the repository url + ecosystem name. This will make easier to indentify a repository inside the same ecosystem. The categories can be something like issues, commits, etc.
I understand this is more complicated to implement but it will make users life easier. If our internal representation is too complicated for representing this, we can change it to find something better.
Removes the 'category' and 'task' fields from the 'Repository' model and adds them to a new 'DataSet' model. DataSets also have a related project and repository. Signed-off-by: Eva Millán <[email protected]>
List a project's repositories:
GET /ecosystems/<name>/project/<name>/repos/
Create a dataset (also creates the repository if it does not exist):
POST /ecosystems/<name>/project/<name>/repos/
data = { uri, datasource_type, category, scheduler }
Get a single repository:
GET /ecosystems/<name>/project/<name>/repos/<uuid>/
Get a dataset from a repository:
GET /ecosystems/<name>/project/<name>/repos/<uuid>/categories/<category>
Delete a dataset (also cancels task):
DELETE /ecosystems/<name>/project/<name>/repos/<uuid>/categories/<category>
List a project's children (subprojects and repositories):
GET /ecosystems/<name>/project/<name>/children/
Signed-off-by: Eva Millán <[email protected]>
|
I updated the PR to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits repository data into
repositoryanddataset. Arepositoryconsists of a datasource type and a URI, while adatasetconsists of a related project, a category, a task and a repository.The PR removes the
/datasources/add_repositoryand/datasources/repositoriesviews and replaces them with REST endpoints to list and manage datasets:GET /ecosystems/<name>/project/<name>/datasets/. Can be filtered by datasource, category and URI.POST /ecosystems/<name>/project/<name>/datasets/GET /ecosystems/<name>/project/<name>/datasets/<id>/DELETE /ecosystems/<name>/project/<name>/datasets/<id>/GET /ecosystems/<name>/project/<name>/children/. Can be filtered by term.