Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[schema] Update dockerhub.csv #814

Merged
merged 1 commit into from
Mar 22, 2020
Merged

[schema] Update dockerhub.csv #814

merged 1 commit into from
Mar 22, 2020

Conversation

vchrombie
Copy link
Member

This PR updates the dockerhub schema to the latest format.
Reference to #803

@coveralls
Copy link

coveralls commented Mar 20, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2033

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.758%
Totals Coverage Status
Change from base Build 2032: 0.0%
Covered Lines: 7044
Relevant Lines: 9298
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2025

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 75.747%
Totals Coverage Status
Change from base Build 2019: -0.01%
Covered Lines: 7043
Relevant Lines: 9298
💛 - Coveralls

valeriocos
valeriocos reviewed Mar 21, 2020
View reviewed changes
Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good @vchrombie, thank you for your effort. Would be possible to add the description of each field (something similar to https://github.com/chaoss/grimoirelab-elk/blob/master/schema/git.csv)?

Please note that some descriptions can be taken from existing CSVs

@vchrombie vchrombie force-pushed the update-dockerhub-schema branch from c456333 to 41bf585 Compare March 21, 2020 20:09
@vchrombie
Copy link
Member Author

Hi @valeriocos
The dockerhub schema is completed. It is ready for review.
It has 3 commits as of now.

  1. 3848aee, which updates all the fields with the latest index
  2. 4446298, which updates the aggregatable column of the fields
  3. 41bf585, which updates the description column of the field (this might need a review 😅 )

Please review it when you are free. After the PR is approved, I will squash all these commits into 1.
Thanks. 🙂

valeriocos
valeriocos approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vchrombie! good job!

Please squash the commits and ping me when I can merge the PR.

@vchrombie
[schema] Update dockerhub.csv
afa6f66 
This commit updates the fields of the dockerhub schema and
updates the schema to the latest format by adding aggregatable
and description columns to the fields.

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@vchrombie vchrombie force-pushed the update-dockerhub-schema branch from 41bf585 to afa6f66 Compare March 22, 2020 10:52
@vchrombie
Copy link
Member Author

Hi @valeriocos

I have squashed the commits too. Please let me know if there are any more changes to do. 🙂

@valeriocos
Copy link
Member

Thank you @vchrombie !

@valeriocos valeriocos merged commit 81c490e into chaoss:master Mar 22, 2020
@vchrombie vchrombie deleted the update-dockerhub-schema branch May 26, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriocos valeriocos valeriocos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vchrombie @coveralls @valeriocos