Skip to content

Fix, which delets valid layer if CreateInstace returned bad result #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JakubNowak16 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix, which delets valid layer if CreateInstace returned bad result #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added bin/Release/12_SimpleGeometryShader_VK.exe
View file
Open in desktop
Binary file not shown.
Binary file added lib/Release/glfw3.lib
View file
Open in desktop
Binary file not shown.
13 changes: 12 additions & 1 deletion tinyvk.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3051,7 +3051,18 @@ void tr_internal_vk_create_instance(const char* app_name, tr_renderer* p_rendere
create_info.enabledExtensionCount = extension_count;
create_info.ppEnabledExtensionNames = extensions;
VkResult vk_res = vkCreateInstance(&create_info, NULL, &(p_renderer->vk_instance));
assert(VK_SUCCESS == vk_res);

if (VK_SUCCESS != vk_res)
{
TINY_RENDERER_DECLARE_ZERO(VkInstanceCreateInfo, create_info_no_validation_layers);
create_info_no_validation_layers = create_info;
create_info_no_validation_layers.enabledLayerCount = 0;
create_info_no_validation_layers.ppEnabledLayerNames = NULL;
VkResult vk_res_no_validation_layers = vkCreateInstance(&create_info_no_validation_layers, NULL, &(p_renderer->vk_instance));
assert(VK_SUCCESS == vk_res_no_validation_layers);
}

//assert(VK_SUCCESS == vk_res);
}

// Debug
Expand Down