Consider ptrs/refs when mapping | Don't decomp empty funcs | Handle empty func lines | Accept more src extensions #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VelocityRa
changed the title
Owner
|
The ast::for_each_node function should traverse the value types of pointers/references anyway, although the physical_type call is interesting. It would make references to a typedef count as references to the underlying type. Do you have any examples where this leads to better output? |
Helps with eg. when func args are typedef'ed structs.
Happens if there's a decompilation error, and then it breaks parsing (there are gigantic files emitted as the size is wrong)
Contributor
Author
|
Pushed a more generic way to handle it. |
Owner
|
Looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.