This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Move trailing option into Router. Use its value as default for routes. #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmillr
added a commit
that referenced
this pull request
Jan 4, 2014
Move trailing option into Router. Use its value as default for routes.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked #727. Also made some refactoring and added more tests.
Question. What should we do in the case when you pass a pattern with a trailing slash directly into
Router::match? IMO, we should truncate the slash internally, so there won't be any difference between ordinary kind of pattern and this one.Note. If we then decide to change default value for the
trailingoption totrue, then many tests will fail, because they use hard-coded URLs without slashes for checking result.