fix(iOS): add support for dynamic frameworks #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one uses CocoaPods and installs the 'Analytics' pod using the option for dyamic frameworks (use_frameworks!) The import of SEGAnalytics will no longer work. With this support we support dynamic frameworks, while being backwards compatible.
|
I tried your fix with and without I tried #23 too. Any idea ? |
|
Not using frameworks, but still seeing Any thoughts or ideas? |
|
Found solution. Add this line to the SegmentAnalytics.podspec file Should fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one uses CocoaPods and installs the 'Analytics' pod using the option for dyamic frameworks (use_frameworks!) The import of SEGAnalytics will no longer work. With this support we support dynamic frameworks, while being backwards compatible.