Skip to content

Fix/react native 0.47 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix/react native 0.47 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a872e5
Fix missing bracket
Genitivo Aug 4, 2017
d668f7f
remove @Override method that are deprecated since react-native 0.47
Genitivo Jan 4, 2018
423fe46
Merge branch 'master' into fix/react_native_0.47
Genitivo Jan 4, 2018
6a8b391
Merge branch 'master' into fix/react_native_0.47
Genitivo Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ public SegmentAnalyticsModule(ReactApplicationContext reactContext) {
super(reactContext);
}

@Override
public String getName() {
return "SegmentAnalytics";
}
Expand Down
2 changes: 0 additions & 2 deletions android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

public class SegmentAnalyticsPackage implements ReactPackage {

@Override
public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
return Arrays.<NativeModule>asList(new SegmentAnalyticsModule(reactContext));
}
Expand All @@ -29,7 +28,6 @@ public List<Class<? extends JavaScriptModule>> createJSModules() {
return Collections.emptyList();
}

@Override
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
return Collections.emptyList();
}
Expand Down