Resolved drawing board to scale with mobile#34
Conversation
added 3 commits
September 28, 2017 07:24
Updated Bootstrap libraries to version 4.0 beta to update the libraries
Beautify'ed the code
Fixed drawing board to scale properly for mobile
charmaine
reviewed
Oct 1, 2017
| overflow: hidden; | ||
| min-height: 60px; | ||
| margin: 0 auto; | ||
| width: 600px; |
Owner
There was a problem hiding this comment.
Would you mind changing this to make the colours and "New Color" button scalable for mobile too?
(ie width: 100%; instead of width:600px;)
charmaine
requested changes
Oct 1, 2017
Owner
There was a problem hiding this comment.
Hey! @beefjerkie! Thanks for fixing up the code and for taking the initiative to make it more mobile-friendly! 🎊
Ahh will have to do some ignore space conflicts merging in css/drawingboard.css 😂
But otherwise, this looks great!
Let me know if you decide to work on the edit and I'll review the changes once you think it's ready. 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed drawing board to scale properly for mobile and adjusted some of the code to be neater for future edits 👍