Enable scale title stroke (12092) #12130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeLenaleee
requested changes
Oct 12, 2025
src/core/core.scale.js
Outdated
Comment on lines
1599
to
1600
| let strokeWidth = title.strokeWidth; | ||
| let strokeColor = title.strokeColor; |
There was a problem hiding this comment.
Suggested change
| let strokeWidth = title.strokeWidth; | |
| let strokeColor = title.strokeColor; |
src/core/core.scale.js
Outdated
Comment on lines
1620
to
1621
| strokeColor: strokeColor, | ||
| strokeWidth: strokeWidth |
There was a problem hiding this comment.
Since we only use it here it is not necesarry to put it in a separate variable.
Suggested change
| strokeColor: strokeColor, | |
| strokeWidth: strokeWidth | |
| strokeColor: title.strokeColor, | |
| strokeWidth: title.strokeWidth |
Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 4.1.0 to 4.2.0. - [Release notes](https://github.com/pnpm/action-setup/releases) - [Commits](pnpm/action-setup@v4.1.0...v4.2.0) --- updated-dependencies: - dependency-name: pnpm/action-setup dependency-version: 4.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…zes/Chart.js into enable-scale-title-stroke rebase
Added an image based test. Let me know if that's not the appropriate way to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Stroke Color and Width to Cartesian scale options, and pass them to drawTitle() so they can be used on the titles for Cartesian scales
Example: https://codepen.io/asmenezes/pen/zxrzaEx