Update retrieve to accept query params #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wscourge
force-pushed
the
wiktor/ome-418-add-validation_type-support-to-invoices-line-items-and
branch
from
97eb95f to
82f2258
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the retrieve method to accept query parameters for filtering API requests. The changes enable passing optional query parameters to retrieve operations, allowing callers to request additional data or filter results.
Key Changes:
- Modified
GetTrait::retrieve()andGetTrait::get()to accept an optionalarray $queryparameter - Added new
getWithQuery()method call when query parameters are provided - Added comprehensive test coverage for various query parameter scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Service/GetTrait.php | Updated retrieve/get methods to accept and handle optional query parameters |
| tests/Unit/InvoiceTest.php | Added tests for Invoice retrieval with validation_type and other query parameters |
| tests/Unit/DataSourceTest.php | Added tests for DataSource retrieval with processing status and other settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wscourge
force-pushed
the
wiktor/ome-418-add-validation_type-support-to-invoices-line-items-and
branch
from
e4e0185 to
c56fcfd
Compare
swember
approved these changes
Jan 6, 2026
wscourge
deleted the
wiktor/ome-418-add-validation_type-support-to-invoices-line-items-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.