Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: remove jsonrpc feature flag #6417

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Simon-Laux
Copy link
Contributor

  • build!: remove jsonrpc feature flag, since it is enabled everywhere by default since some time now. breaking, because existing build scripts might need to be adjusted
  • cargo fmt

see also #6326 (comment)

Copy link
Collaborator

@iequidoo iequidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message needs to be improved:

build(ffi)!: remove jsonrpc feature flag

It is enabled everywhere by default since some time now. Breaking, because existing build scripts might need to be adjusted.

@Simon-Laux Simon-Laux changed the title build!: remove jsonrpc feature flag, since it is enabled everywhere by default since some time now. breaking, because existing build scripts might need to be adjusted build!: remove jsonrpc feature flag Jan 8, 2025
It is enabled everywhere by default since some time now. Breaking, because existing build scripts might need to be adjusted.
@link2xt link2xt force-pushed the simon/remove-jsonrpc-feature-from-ffi branch from e402b34 to b377ec2 Compare January 9, 2025 15:34
@link2xt link2xt enabled auto-merge (rebase) January 9, 2025 15:34
@link2xt link2xt merged commit a9e177f into main Jan 9, 2025
36 checks passed
@link2xt link2xt deleted the simon/remove-jsonrpc-feature-from-ffi branch January 9, 2025 15:56
Hocuri added a commit to deltachat/deltachat-android that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants