CI: don't check lint when deploying to staging #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This failed (to be expected, so let's rebase on top of #591 to see whether the undeployed changes test passes now: |
missytake
force-pushed
the
ci-fail-on-lint
branch
from
5e78b1f to
c808a4f
Compare
|
An idea would also be to just remove the lint check from the deploy-on-staging-CI steps, as the ci.yaml workflows already check it. I guess we don't really want our whole deployment to fail just because of a code style disagreement. |
missytake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cmdeploy fmt -vstep changes the local checkout of the repository, but returns exit code 0 - and then later, the undeployed changes test fails, with an unhelpful error which doesn't really point to the actual problem (the linting).Actually CI should already fail at the linting step.Actually we don't need to check lint in this CI job, as another already checks it.