Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DKIM-Signature from incoming mail after checking #533

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Mar 25, 2025

Closes #530

@link2xt link2xt force-pushed the link2xt/ignore-dkim-header branch from 35880c1 to 290525f Compare March 25, 2025 02:21
@@ -0,0 +1 @@
/^DKIM-Signature:/ IGNORE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also scrub Authentication-Results then?

Copy link
Contributor Author

@link2xt link2xt Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see Authentication-Results, there is nothing that adds them. OpenDKIM is not configured to add them apparently.

Above the Content-Type header (the last one added by the client) I only see DKIM-Signature, Received and Return-Path. Maybe Received and Return-Path can be removed to reduce the amount of stored metadata further. These headers come from the receiving server.

Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (modulo my review comment)

@feld
Copy link
Collaborator

feld commented Mar 26, 2025

Does this actually work? I tried applying this to my server but I still see the DKIM-Signature header in the maildir files on disk

@feld
Copy link
Collaborator

feld commented Mar 26, 2025

Local mails didn't get DKIM-Signature stripped and this broke federation for me

@link2xt link2xt marked this pull request as draft March 26, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove DKIM signature after checking it
3 participants