WhatsApp Group Conversation #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves fundamental compatibility issues blocking WhatsApp group message support: 1. Fix WHATSAPP_GROUP_JID_REGEX to properly match group JIDs ([email protected] format) 2. Update ContactInbox validation to allow group JIDs for whatsapp_web provider 3. Fix message sanitization to preserve group JIDs during sending 4. Add comprehensive test coverage with 15 new tests All existing functionality preserved with zero breaking changes. Group JIDs only allowed for whatsapp_web provider for security. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…t details in WhatsApp service
… contact validation and processing
…nder name display and message processing
…nd adding missing extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive support for WhatsApp group conversations. It updates both backend and frontend logic to correctly identify group chats, process group messages, and display sender names for individual messages within group conversations. The changes ensure that group messages are attributed to the correct sender and that group contacts are managed distinctly from individual contacts.
WhatsApp Group Conversation Detection and Processing:
isWhatsAppGroupConversation,shouldShowSenderNames) to detect WhatsApp group conversations and determine when to show sender names in the frontend (app/javascript/dashboard/helper/groupConversationHelper.js).app/services/whatsapp/incoming_message_whatsapp_web_service.rb). This includes new methods for handling incoming/outgoing group messages and setting up group contacts. [1] [2] [3]app/models/contact_inbox.rb).Frontend UI Enhancements for Group Conversations:
isGroupConversationprop, enabling conditional display of sender names and avatars for group chats (Message.vue,MessageList.vue,MessagesView.vue). [1] [2] [3]Message.vue). [1] [2] [3] [4] [5]General Improvements and Refactoring:
contact_infoto the WhatsApp channel model for easier access to group names (app/models/channel/whatsapp.rb)..devcontainer/devcontainer.json).These changes collectively ensure robust handling and display of WhatsApp group conversations across the application.