fix: download cache #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
iamsivin
approved these changes
Jan 29, 2025
scmmishra
added a commit
to chatwoot/chatwoot
that referenced
this pull request
Jan 29, 2025
# Pull Request Template ## Description Ref: chatwoot/utils#39 --------- Co-authored-by: Shivam Mishra <[email protected]>
conexaoazul
pushed a commit
to conexaoazul/magicachat
that referenced
this pull request
Mar 5, 2025
# Pull Request Template ## Description Ref: chatwoot/utils#39 --------- Co-authored-by: Shivam Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading images programatically, the request can often fail with a CORS error. This happens even if the CORS headers are correctly set for the S3 bucket.
The problem here is the browser, once the image is loaded correctly on the browser, chrome will store the response in it's cache. And when we fetch the image in the
downloadFilemethod. The cached response is served. Which, does not have theAccess-Control-Allow-Originheader.Multiple threads across the internet highlight this issue
This PR attempts to fix this by skipping cache when raising the fetch request