feat: add split words method #51
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new splitWords method to enhance string splitting behavior, especially for CSV-like inputs with quoted phrases.
- Adds the splitWords function with CSV parsing like behavior in src/string.ts
- Updates tests in test/string.test.ts to validate multiple input scenarios
- Updates the module export in src/index.ts to include splitWords
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/string.test.ts | Adds tests for various splitWords input cases |
| src/string.ts | Implements the CSV-like splitWords function |
| src/index.ts | Updates exports to include splitWords |
Comments suppressed due to low confidence (1)
test/string.test.ts:41
- [nitpick] Additional test cases for trailing commas and consecutive delimiters would help ensure that splitWords consistently handles all CSV edge cases.
describe('#splitWords', () => {
size-limit report 📦
|
| // Check for mismatched quotes | ||
| if (inQuotes) { | ||
| throw new Error('Mismatched quotes in input string'); | ||
| } |
There was a problem hiding this comment.
Do we need to handle this? A query with a single quote should be valid right?
There was a problem hiding this comment.
It made sense to do this, although it makes the " an invalid search candidate, I think it still works.
Since there's not visual feedback on the frontend about how the values were sent, if we allow mismatched quote, we will have to break the sentence through some fallback method which will introduce ambiguity.
There was a problem hiding this comment.
@pranavrajs let me know what you think here, we can proceed with merging this
This PR adds a split words method that goes beyond the naive splitting using
string.split(',')to a approach more akin to CSV parsing, that allows quoted blocks to be treated as their own candidate.So
"apple, mango", orangewill be split as['apple, mango', 'orange']