feat: validate that monitors are configured for single retry only [sc-24878] #1106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation to make sure that monitors only use retry strategies they support.
A similar change is implemented for CheckGroups and Checks. Without delving too deep into the types, the following snippet should give you the general idea:
The
RetryStrategyBuilder
has been updated to return compatible structs.All of these changes are backwards compatible with the following exceptions:
maxRetries
whentype: 'NO_RETRIES'
) will now result in a compilation error. Therefore, if a user had used an invalid combination before, that will now fail (depending on the TypeScript loader type - jiti will not error).retryStrategy
has been specified in the Checkly config file, the user will now get a validation error on deploy/test/etc.Affected Components
Notes for the Reviewer
New Dependency Submission