feat(continuous_screening): Expose continuous task status#1315
Draft
OrriMandarin wants to merge 1 commit into
Draft
feat(continuous_screening): Expose continuous task status#1315OrriMandarin wants to merge 1 commit into
OrriMandarin wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds “continuous screening debug” endpoints and UI to let admins inspect continuous screening processing state (update jobs and delta tracks) from the App Builder settings.
Changes:
- Extended MarbleCore OpenAPI spec + regenerated API client to expose two debug listing endpoints (update jobs, delta tracks).
- Added new admin-only Settings page + resources routes to fetch/paginate those debug datasets.
- Introduced shared Settings
PaginationRowcomponent and reused it for Audit Events pagination.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/marble-api/src/generated/marblecore-api.ts | Adds generated client functions to call the new debug endpoints. |
| packages/marble-api/openapis/marblecore-api/continuous-screenings.yml | Defines the two new debug paths and associated response schemas. |
| packages/marble-api/openapis/marblecore-api.yaml | Wires new debug paths into the top-level OpenAPI document. |
| packages/app-builder/src/utils/routes/types.ts | Registers new Settings + resources route types. |
| packages/app-builder/src/utils/routes/routes.ts | Registers new Settings + resources routes in the route manifest. |
| packages/app-builder/src/services/settings-access.ts | Adds a new “debug” settings section (admin-only) linking to the page. |
| packages/app-builder/src/routes/ressources+/settings+/cs-debug-update-jobs.ts | Adds admin-only resources loader for update jobs. |
| packages/app-builder/src/routes/ressources+/settings+/cs-debug-delta-tracks.ts | Adds admin-only resources loader for delta tracks. |
| packages/app-builder/src/routes/_builder+/settings+/continuous-screening-debug.tsx | Adds the admin-only Settings page route + querystring limit handling. |
| packages/app-builder/src/repositories/ContinuousScreeningRepository.ts | Adds repository methods to call MarbleCore debug endpoints and adapt DTOs. |
| packages/app-builder/src/queries/continuous-screening/debug-update-jobs.ts | Adds React Query infinite query for update jobs. |
| packages/app-builder/src/queries/continuous-screening/debug-delta-tracks.ts | Adds React Query infinite query for delta tracks. |
| packages/app-builder/src/models/continuous-screening-debug.ts | Introduces typed models + DTO adapters for the debug payloads. |
| packages/app-builder/src/locales/fr/settings.json | Adds i18n keys for the debug UI (currently English in fr). |
| packages/app-builder/src/locales/en/settings.json | Adds i18n keys for the debug UI (English). |
| packages/app-builder/src/locales/ar/settings.json | Adds i18n keys for the debug UI (currently English in ar). |
| packages/app-builder/src/components/Settings/PaginationRow.tsx | New shared pagination UI component for Settings pages. |
| packages/app-builder/src/components/Settings/ContinuousScreeningDebug/UpdateJobsTable.tsx | Adds table UI for update jobs. |
| packages/app-builder/src/components/Settings/ContinuousScreeningDebug/DeltaTracksTable.tsx | Adds table UI for delta tracks. |
| packages/app-builder/src/components/Settings/ContinuousScreeningDebug/ContinuousScreeningDebugPage.tsx | Adds page UI (tabs + pagination) composing the tables and queries. |
| packages/app-builder/src/components/Settings/AuditEvents/PaginationRow.tsx | Refactors Audit Events pagination to use the shared component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "continuous_screening_debug.update_jobs.updated_at": "Updated At", | ||
| "continuous_screening_debug.update_jobs.version": "Version", | ||
| "data_display": "Affichage des données", | ||
| "debug": "Debug", |
There was a problem hiding this comment.
The new debug section label is left as "Debug" in the French locale file. If this section is user-facing in the settings sidebar, it should be translated (e.g. "Débogage").
Suggested change
| "debug": "Debug", | |
| "debug": "Débogage", |
| "continuous_screening_debug.update_jobs.updated_at": "Updated At", | ||
| "continuous_screening_debug.update_jobs.version": "Version", | ||
| "data_display": "عرض البيانات", | ||
| "debug": "Debug", |
There was a problem hiding this comment.
The new debug section label is left as "Debug" in the Arabic locale file. If this section is user-facing in the settings sidebar, it should be translated.
Suggested change
| "debug": "Debug", | |
| "debug": "تصحيح الأخطاء", |
Comment on lines
+21
to
+27
| const response = await fetch(endpoint + qs, { | ||
| method: 'GET', | ||
| }); | ||
| const responseData = (await response.json()) as { data: DebugUpdateJobsResponse }; | ||
|
|
||
| return responseData.data; | ||
| }, |
There was a problem hiding this comment.
The queryFn doesn’t check response.ok before parsing/returning JSON. If the resources route returns a non-2xx (e.g., 403 for non-admin or 500), this query can resolve with undefined data and still be marked as isSuccess, so the error UI won’t render. Please throw on non-OK responses (and ideally surface the server error message) before calling response.json() / returning responseData.data.
Comment on lines
+21
to
+27
| const response = await fetch(endpoint + qs, { | ||
| method: 'GET', | ||
| }); | ||
| const responseData = (await response.json()) as { data: DebugDeltaTracksResponse }; | ||
|
|
||
| return responseData.data; | ||
| }, |
There was a problem hiding this comment.
The queryFn doesn’t check response.ok before parsing/returning JSON. On non-2xx responses, this can incorrectly resolve the promise and mark the query as isSuccess, preventing the page’s error state from displaying. Throw on non-OK responses before reading JSON / returning responseData.data.
Contributor
There was a problem hiding this comment.
This comment seems correct
Comment on lines
+41
to
+58
| "continuous_screening_debug": "Continuous Screening", | ||
| "continuous_screening_debug.delta_tracks.created_at": "Created At", | ||
| "continuous_screening_debug.delta_tracks.dataset_file": "Dataset File", | ||
| "continuous_screening_debug.delta_tracks.object_id": "Object ID", | ||
| "continuous_screening_debug.delta_tracks.object_type": "Object Type", | ||
| "continuous_screening_debug.delta_tracks.operation": "Operation", | ||
| "continuous_screening_debug.delta_tracks.processed": "Processed", | ||
| "continuous_screening_debug.operation.add": "Add", | ||
| "continuous_screening_debug.operation.delete": "Delete", | ||
| "continuous_screening_debug.operation.update": "Update", | ||
| "continuous_screening_debug.pagination.per_page": "Items per page:", | ||
| "continuous_screening_debug.status.completed": "Completed", | ||
| "continuous_screening_debug.status.failed": "Failed", | ||
| "continuous_screening_debug.status.pending": "Pending", | ||
| "continuous_screening_debug.status.processing": "Processing", | ||
| "continuous_screening_debug.tabs.delta_tracks": "Delta Tracks", | ||
| "continuous_screening_debug.tabs.update_jobs": "Update Jobs", | ||
| "continuous_screening_debug.update_jobs.created_at": "Created At", |
There was a problem hiding this comment.
These new locale strings for the continuous screening debug page are still in English in the French translations file, so fr users will see English UI labels. Please translate the added continuous_screening_debug.* keys (and the new debug section label if it’s user-facing).
Suggested change
| "continuous_screening_debug": "Continuous Screening", | |
| "continuous_screening_debug.delta_tracks.created_at": "Created At", | |
| "continuous_screening_debug.delta_tracks.dataset_file": "Dataset File", | |
| "continuous_screening_debug.delta_tracks.object_id": "Object ID", | |
| "continuous_screening_debug.delta_tracks.object_type": "Object Type", | |
| "continuous_screening_debug.delta_tracks.operation": "Operation", | |
| "continuous_screening_debug.delta_tracks.processed": "Processed", | |
| "continuous_screening_debug.operation.add": "Add", | |
| "continuous_screening_debug.operation.delete": "Delete", | |
| "continuous_screening_debug.operation.update": "Update", | |
| "continuous_screening_debug.pagination.per_page": "Items per page:", | |
| "continuous_screening_debug.status.completed": "Completed", | |
| "continuous_screening_debug.status.failed": "Failed", | |
| "continuous_screening_debug.status.pending": "Pending", | |
| "continuous_screening_debug.status.processing": "Processing", | |
| "continuous_screening_debug.tabs.delta_tracks": "Delta Tracks", | |
| "continuous_screening_debug.tabs.update_jobs": "Update Jobs", | |
| "continuous_screening_debug.update_jobs.created_at": "Created At", | |
| "continuous_screening_debug": "Surveillance continue", | |
| "continuous_screening_debug.delta_tracks.created_at": "Créé le", | |
| "continuous_screening_debug.delta_tracks.dataset_file": "Fichier du jeu de données", | |
| "continuous_screening_debug.delta_tracks.object_id": "ID de l'objet", | |
| "continuous_screening_debug.delta_tracks.object_type": "Type d'objet", | |
| "continuous_screening_debug.delta_tracks.operation": "Opération", | |
| "continuous_screening_debug.delta_tracks.processed": "Traité", | |
| "continuous_screening_debug.operation.add": "Ajouter", | |
| "continuous_screening_debug.operation.delete": "Supprimer", | |
| "continuous_screening_debug.operation.update": "Mettre à jour", | |
| "continuous_screening_debug.pagination.per_page": "Éléments par page :", | |
| "continuous_screening_debug.status.completed": "Terminé", | |
| "continuous_screening_debug.status.failed": "Échoué", | |
| "continuous_screening_debug.status.pending": "En attente", | |
| "continuous_screening_debug.status.processing": "En cours de traitement", | |
| "continuous_screening_debug.tabs.delta_tracks": "Pistes Delta", | |
| "continuous_screening_debug.tabs.update_jobs": "Tâches de mise à jour", | |
| "continuous_screening_debug.update_jobs.created_at": "Créé le", |
Comment on lines
+41
to
+58
| "continuous_screening_debug": "Continuous Screening", | ||
| "continuous_screening_debug.delta_tracks.created_at": "Created At", | ||
| "continuous_screening_debug.delta_tracks.dataset_file": "Dataset File", | ||
| "continuous_screening_debug.delta_tracks.object_id": "Object ID", | ||
| "continuous_screening_debug.delta_tracks.object_type": "Object Type", | ||
| "continuous_screening_debug.delta_tracks.operation": "Operation", | ||
| "continuous_screening_debug.delta_tracks.processed": "Processed", | ||
| "continuous_screening_debug.operation.add": "Add", | ||
| "continuous_screening_debug.operation.delete": "Delete", | ||
| "continuous_screening_debug.operation.update": "Update", | ||
| "continuous_screening_debug.pagination.per_page": "Items per page:", | ||
| "continuous_screening_debug.status.completed": "Completed", | ||
| "continuous_screening_debug.status.failed": "Failed", | ||
| "continuous_screening_debug.status.pending": "Pending", | ||
| "continuous_screening_debug.status.processing": "Processing", | ||
| "continuous_screening_debug.tabs.delta_tracks": "Delta Tracks", | ||
| "continuous_screening_debug.tabs.update_jobs": "Update Jobs", | ||
| "continuous_screening_debug.update_jobs.created_at": "Created At", |
There was a problem hiding this comment.
These new locale strings for the continuous screening debug page are still in English in the Arabic translations file, so ar users will see English UI labels. Please translate the added continuous_screening_debug.* keys (and the new debug section label if it’s user-facing).
Suggested change
| "continuous_screening_debug": "Continuous Screening", | |
| "continuous_screening_debug.delta_tracks.created_at": "Created At", | |
| "continuous_screening_debug.delta_tracks.dataset_file": "Dataset File", | |
| "continuous_screening_debug.delta_tracks.object_id": "Object ID", | |
| "continuous_screening_debug.delta_tracks.object_type": "Object Type", | |
| "continuous_screening_debug.delta_tracks.operation": "Operation", | |
| "continuous_screening_debug.delta_tracks.processed": "Processed", | |
| "continuous_screening_debug.operation.add": "Add", | |
| "continuous_screening_debug.operation.delete": "Delete", | |
| "continuous_screening_debug.operation.update": "Update", | |
| "continuous_screening_debug.pagination.per_page": "Items per page:", | |
| "continuous_screening_debug.status.completed": "Completed", | |
| "continuous_screening_debug.status.failed": "Failed", | |
| "continuous_screening_debug.status.pending": "Pending", | |
| "continuous_screening_debug.status.processing": "Processing", | |
| "continuous_screening_debug.tabs.delta_tracks": "Delta Tracks", | |
| "continuous_screening_debug.tabs.update_jobs": "Update Jobs", | |
| "continuous_screening_debug.update_jobs.created_at": "Created At", | |
| "continuous_screening_debug": "الفحص المستمر", | |
| "continuous_screening_debug.delta_tracks.created_at": "تاريخ الإنشاء", | |
| "continuous_screening_debug.delta_tracks.dataset_file": "ملف مجموعة البيانات", | |
| "continuous_screening_debug.delta_tracks.object_id": "معرّف الكائن", | |
| "continuous_screening_debug.delta_tracks.object_type": "نوع الكائن", | |
| "continuous_screening_debug.delta_tracks.operation": "العملية", | |
| "continuous_screening_debug.delta_tracks.processed": "مُعالَج", | |
| "continuous_screening_debug.operation.add": "إضافة", | |
| "continuous_screening_debug.operation.delete": "حذف", | |
| "continuous_screening_debug.operation.update": "تحديث", | |
| "continuous_screening_debug.pagination.per_page": "العناصر لكل صفحة:", | |
| "continuous_screening_debug.status.completed": "مكتمل", | |
| "continuous_screening_debug.status.failed": "فشل", | |
| "continuous_screening_debug.status.pending": "قيد الانتظار", | |
| "continuous_screening_debug.status.processing": "جارٍ المعالجة", | |
| "continuous_screening_debug.tabs.delta_tracks": "مسارات دلتا", | |
| "continuous_screening_debug.tabs.update_jobs": "مهام التحديث", | |
| "continuous_screening_debug.update_jobs.created_at": "تاريخ الإنشاء", |
Contributor
Pascal-Delange
left a comment
Pascal-Delange
left a comment
There was a problem hiding this comment.
Looks generally alright !
Now, I didn't get to try this out with pagination because not enough data in my local instance.
What's missing IMO before possibly merging this:
- clearer translations (non-technical translations)
- wondering if a good place for this is in settings or in a kinda hidden section in monitoring (I'd still say, the latter)
- human intellegible callouts/explanation texts that explain what is what
Comment on lines
+21
to
+27
| const response = await fetch(endpoint + qs, { | ||
| method: 'GET', | ||
| }); | ||
| const responseData = (await response.json()) as { data: DebugDeltaTracksResponse }; | ||
|
|
||
| return responseData.data; | ||
| }, |
Contributor
There was a problem hiding this comment.
This comment seems correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked: checkmarble/marble-backend#1513