Skip to content

test(e2e): add detection > decisions URL-state and filter-bar smokes#1552

Merged
Djauron merged 2 commits into
mainfrom
feat/e2e-decisions
May 20, 2026
Merged

test(e2e): add detection > decisions URL-state and filter-bar smokes#1552
Djauron merged 2 commits into
mainfrom
feat/e2e-decisions

Conversation

@Djauron
Copy link
Copy Markdown
Contributor

@Djauron Djauron commented May 19, 2026

Covers the highest-leverage analyst page with 5 client-side tests: page chrome, search-by-id form gating, the 9-item filter menu catalog, applying triggerObjectId via the menu, and clearing a chip from a preset URL.

Summary by CodeRabbit

  • Tests
    • Added comprehensive end-to-end tests for the Decisions page, covering page navigation, filter functionality, search input validation, and filter application with URL parameter handling.

Review Change Stack

Covers the highest-leverage analyst page with 5 client-side tests: page
chrome, search-by-id form gating, the 9-item filter menu catalog,
applying triggerObjectId via the menu, and clearing a chip from a
preset URL.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

A new Playwright E2E test suite validates the Decisions page at /detection/decisions. Tests verify page navigation, visibility of search and filter UI, search button state management, filter menu options, filter application with URL state synchronization, and filter clearing behavior.

Changes

Decisions Page E2E Test Suite

Layer / File(s) Summary
Test setup and page load verification
packages/tests/e2e/decisions.spec.ts
Playwright imports and a case-insensitive locator helper for the Filters button are defined. The suite's first test loads /detection/decisions, waits for hydration, and asserts the page remains on the decisions path with Filters trigger and search input visible.
Search button and filter menu behavior
packages/tests/e2e/decisions.spec.ts
Tests confirm the search button starts disabled and becomes enabled only after entering a value in the "Search by id" input. A separate test opens the filters menu and validates all nine expected filter options are visible.
Filter application and state clearing
packages/tests/e2e/decisions.spec.ts
Tests apply the triggerObjectId filter by selecting "Object ID", entering a UUID, and pressing Enter. URL is verified to contain the triggerObjectId query parameter, and the rendered chip displays the expected label. A final test seeds the URL with the filter parameter, verifies the chip appears, clears it via an X button, and confirms the URL parameter and chip both disappear.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

M

Suggested reviewers

  • william-schlegel
  • ChibiBlasphem

A test suite doth now shine with Playwright's grace,
The Decisions page tested at its rightful place,
Filters, searches, and chips alike—all checked with care,
State and URL dance in perfect pair.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding E2E tests for the detection > decisions page focusing on URL state and filter bar functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/e2e-decisions

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@william-schlegel william-schlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Djauron Djauron enabled auto-merge (squash) May 20, 2026 10:14
@coderabbitai coderabbitai Bot added the M medium label May 20, 2026
@Djauron Djauron merged commit 081d5b1 into main May 20, 2026
5 of 6 checks passed
@Djauron Djauron deleted the feat/e2e-decisions branch May 20, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants