Skip to content

Deployed to Maven Central #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Anmol202005
Copy link
Collaborator

Fixes: #6
Configured pom.xml for maven central deployment.

<artifactId>oss-parent</artifactId>
<version>9</version>
</parent>

<groupId>org.checkstyle.autofix</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can org.checkstyle only for group.
it is ok to have plugins/tools to be just under "checkstyle"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the patch-filter project I see latest master has <groupId>com.puppycrawl.tools</groupId>, shall we go with the same groupId? Better to agree on this now while we are still at the start of the project

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://repo1.maven.org/maven2/org/checkstyle

Is not existing, so it means it will be a special process to claim ownership of such domain.

Lets use group common for all , as Ruslan suggested
https://repo1.maven.org/maven2/com/puppycrawl/tools/

@romani
Copy link
Member

romani commented Jun 8, 2025

I think we should not be obsessed to deploy to maven central jar too early.

We can always put jar to maven local repository and use special profile to activate openrewrite to fix code.

scenario:
user do code changes
use run "mvn verify"
it failing with errors
user run "mvn ..... -Pautofix" to fix violations.

it will help us take maturity withtout bothering much existing dev process of checkstyle. We will share knowledge on this, so users will likely to run it manually and give feedback and not be blocked if any problems happens with auto-fixes.

@rdiachenko
Copy link
Collaborator

@Anmol202005 what's the status of this PR? Let's finish it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy to Maven Central.
3 participants