Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Texts Updated #8396

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Link Texts Updated #8396

merged 5 commits into from
Apr 23, 2024

Conversation

dishanktiwari2501
Copy link
Collaborator

@dishanktiwari2501 dishanktiwari2501 commented Mar 13, 2024

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-3205

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: dishanktiwari2501 <[email protected]>
Signed-off-by: dishanktiwari2501 <[email protected]>
@dishanktiwari2501 dishanktiwari2501 added the documentation Anything related to the Automate docs. label Mar 13, 2024
@dishanktiwari2501 dishanktiwari2501 self-assigned this Mar 13, 2024
@dishanktiwari2501 dishanktiwari2501 requested a review from a team as a code owner March 13, 2024 11:46
Copy link

netlify bot commented Mar 13, 2024

βœ… Deploy Preview for chef-automate ready!

Name Link
πŸ”¨ Latest commit 7769765
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/660a4f329cf265000808adbc
😎 Deploy Preview https://deploy-preview-8396--chef-automate.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@IanMadd IanMadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some feedback

You also have several links still formatted like this --> Click [here] and Click here to know more [details] and [Click here to know how to upgrade to Chef Automate 4.x]

Signed-off-by: dishanktiwari2501 <[email protected]>
Signed-off-by: dishanktiwari2501 <[email protected]>
Signed-off-by: dishanktiwari2501 <[email protected]>

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@punitmundra punitmundra merged commit efd2f67 into main Apr 23, 2024
11 of 13 checks passed
@punitmundra punitmundra deleted the dt-correct_link_texts branch April 23, 2024 05:16
kalroy pushed a commit that referenced this pull request Oct 8, 2024
* updated the doc

Signed-off-by: dishanktiwari2501 <[email protected]>

* fixed feedbacks

Signed-off-by: dishanktiwari2501 <[email protected]>

* changes updated

Signed-off-by: dishanktiwari2501 <[email protected]>

* changes updated for the broken links

Signed-off-by: dishanktiwari2501 <[email protected]>

---------

Signed-off-by: dishanktiwari2501 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants