[CHEF-18932] Changes to stop exposing credentials through plain text in oc-id #8779
Conversation
Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: RoyShravani <[email protected]>
|
| @@ -47,7 +61,11 @@ source "{{pkg.svc_config_path}}/scripts/set_env_vars.sh" | |||
| # pls make sure export happens after the file is updated. | |||
| export CHEF_SECRETS_DATA=$(cat config/private-chef-secrets.json) | |||
|
|
|||
| bundle exec bin/rake db:migrate | |||
| secrets-helper exec \ | |||
There was a problem hiding this comment.
@RoyShravani Do we have any changes in chef-server/oc-id ? I see the export DATABASE_URL=$output in line 43...
There was a problem hiding this comment.
Do we still need the changes form line 64 to 67, as we are exporting the DATABASE_URL
There was a problem hiding this comment.
That's correct, we don't need them. Removed that bit.
There was a problem hiding this comment.
@RoyShravani Do we have any changes in chef-server/oc-id ? I see the
export DATABASE_URL=$outputin line 43...
No, we don't need any changes in chef-server/oc-id
Signed-off-by: RoyShravani <[email protected]>
🔩 Description: What code changed, and why?
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable