-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't treat host:port as an IPv6 address #666
Conversation
… an IPv6 address Change-Id: I1d0ddc309e3e115e458b05bea775edc1252814ab
Thanks for the contribution. However, I think this would exclude a lot of valid IPv6 addresses since a single |
D'oh I misread this. I think this will work apologies for any confusion. |
👍 |
👍 Makes sense. |
This change has the potential to break other configuration - In that case, if someone specified a vip that included a port for bifrost, erchef would not be able to communicate with bifrost. It's the same for other usages. We have an existing issue #50, was the underlying issue you're trying to resolve with this? |
@marcparadise In thinking about this, while I agree with you at a high level, I don't see this change opening up new issues. Nothing /prevented/ users from specifying a port. In the past, such specifications would fail with whatever weird error the relevant component would raise when configured with an invalid IPv6 address. As far as I know, there isn't a valid IPv6 address that contains a single The only downside to merging this would the cost of continuing to support |
Based on the comment:
Is this being deprecated? Or will this be addressed in one form or another? |
Closing this as resolved by #833. Please re-open this PR if the addition of |
Addresses chef-server/665