Add support for chef-client 19 license requirement and habitat install location to chef provisioner #29
Conversation
Signed-off-by: Corey Hemminger <[email protected]>
| # Added for Chef-Client 19+ | ||
| args << "--chef-license-key=#{config[:chef_license_key]}" if config[:chef_license_key] |
There was a problem hiding this comment.
During the RC1 release, we updated only the kitchen-Dokken driver to download the chef-infra-19, which has its own provisioner. We haven't updated the chef_infra provisioner to download and install the hab version of chef-infra-19.
So, if we pass the license key here, it will be used along with the chef-infra-18 and will cause it to fail because it is an unrecognized argument for infra-18.
There was a problem hiding this comment.
There was a problem hiding this comment.
converting to draft, but the if statement only adds the flag if they add the chef_license_key option to the kitchen.yml file. So without it the flag wont be added and thus would work with older versions of chef-client. Still a work in progress as more commands need it.
There was a problem hiding this comment.
by updating the default provisioner here many other kitchen-* plugins will work out of the box, like kitchen-vagrant, without us needing to fork them like kitchen-dokken and can simply be added to chef-test-kitchen-enterprise as additional bundled gems.
There was a problem hiding this comment.
This is also needed to get additional testing of VM's in chef/chef repo's github actions for community testing of code.
…when installed via habitat package or omnibus Signed-off-by: Corey Hemminger <[email protected]>
Stromweld
changed the title
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Description
Adds --chef-license-key flag and value if configured in kitchen.yml file
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.