Skip to content

Harden setup allow_from defaults#376

Open
q107580018 wants to merge 1 commit intochenhg5:mainfrom
q107580018:codex/setup-allow-from-default
Open

Harden setup allow_from defaults#376
q107580018 wants to merge 1 commit intochenhg5:mainfrom
q107580018:codex/setup-allow-from-default

Conversation

@q107580018
Copy link
Copy Markdown
Contributor

Summary

  • default feishu setup and weixin setup to merge the bound user into allow_from
  • preserve allow_from = "*" and deduplicate/compress comma-separated ids when appending
  • add config regression tests for empty, append, and wildcard cases

Test Plan

  • go test ./cmd/cc-connect ./config
  • go test ./... (currently fails on existing unrelated tests in core and platform/wecom)

Copy link
Copy Markdown
Owner

@chenhg5 chenhg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Improved security defaults for setup.

Review summary:

  • feishu setup and weixin setup now merge bound user into allow_from
  • ✅ Preserves allow_from = *
  • ✅ Deduplicates comma-separated IDs
  • ✅ Tests added
  • ✅ CI passes

Better security posture for new installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants