Open
Conversation
chenhg5
approved these changes
Apr 1, 2026
Owner
chenhg5
left a comment
There was a problem hiding this comment.
LGTM. Improved security defaults for setup.
Review summary:
- ✅
feishu setupandweixin setupnow merge bound user intoallow_from - ✅ Preserves
allow_from = * - ✅ Deduplicates comma-separated IDs
- ✅ Tests added
- ✅ CI passes
Better security posture for new installations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feishu setupandweixin setupto merge the bound user intoallow_fromallow_from = "*"and deduplicate/compress comma-separated ids when appendingTest Plan
go test ./cmd/cc-connect ./configgo test ./...(currently fails on existing unrelated tests incoreandplatform/wecom)