fix: avoid web embed build failures#391
Merged
chenhg5 merged 1 commit intochenhg5:mainfrom Apr 2, 2026
Merged
Conversation
chenhg5
approved these changes
Apr 1, 2026
Owner
chenhg5
left a comment
chenhg5
left a comment
There was a problem hiding this comment.
LGTM. Practical fix for build and file handling.
Review summary:
- ✅ Makes web/dist optional (no hard build failure without frontend bundle)
- ✅ Adds .keep to gitignore exception
- ✅ Improves WeCom MIME detection with magic-byte sniffing
- ✅ CI passes
Good fix for fresh checkout builds and WeCom file handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/dist/index.htmlas a hard build failureweb/dist/.keepand only registering embeddedassets when a real frontend bundle is present
.binnames still fall through tomagic-byte sniffing
Why
A fresh source checkout could fail
go test ./...andgo build ./...becauseweb/ embed.gorequiredweb/distbuild artifacts to exist at compile time. Separately,WeCom inbound file MIME detection returned
application/octet-streamtoo early forunknown extensions like
.bin, which broke PNG detection by content.Validation
go1.26.1) for this environmentgo test ./...