docs: clarify admin_from for privileged commands#393
Open
xukp20 wants to merge 1 commit intochenhg5:mainfrom
Open
docs: clarify admin_from for privileged commands#393xukp20 wants to merge 1 commit intochenhg5:mainfrom
xukp20 wants to merge 1 commit intochenhg5:mainfrom
Conversation
chenhg5
approved these changes
Apr 1, 2026
Owner
chenhg5
left a comment
There was a problem hiding this comment.
LGTM. Helpful documentation clarification.
Review summary:
- ✅ Clarifies admin_from placement (project level, not platform options)
- ✅ Documents how to get User ID via /whoami / /status
- ✅ Bilingual docs updated
- ✅ CI passes
Addresses the confusion from #359.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify how
admin_fromshould be configured for privileged commands such as/dir.This documents the configuration detail discussed in #359:
admin_frommust be defined at the[[projects]]level, not under[projects.platforms.options].What changed
admin_fromplacement inconfig.example.toml/diris a privileged command requiringadmin_from/whoamior/statusadmin_from = "*"shortcut and its risk in multi-user environmentsREADME.mdWhy
A user in #359 was able to fix the problem after moving
admin_fromto the correct config level, and suggested documenting it.This PR makes that guidance explicit so users do not accidentally place
admin_fromunder platform options and wonder why privileged commands are still blocked.Validation
upstream/mainbefore editinggo test ./config ./core ./agent/... ./platform/...Note:
go build ./.../go test ./...on a clean latestmaincheckout is currently blocked by missingweb/distin the repository checkout, whichis unrelated to this doc-only change
Related issue