feat(feishu): support runtime domain override#404
Merged
chenhg5 merged 1 commit intochenhg5:mainfrom Apr 2, 2026
Merged
Conversation
chenhg5
approved these changes
Apr 1, 2026
Owner
chenhg5
left a comment
There was a problem hiding this comment.
LGTM. Clean implementation of Feishu domain override.
Review summary:
- ✅ Backward compatible (optional config)
- ✅ URL validation included
- ✅ Documentation updated
- ✅ Tests added
- ✅ CI passes
Good feature for enterprise users with custom Feishu domains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional runtime
domainoverride support for Feishu/Lark platform configuration.Related to #402.
What changed
projects.platforms.options.domainforfeishu/larkdomainis not setconfig.example.tomldocs/feishu.mddocs/usage.mddocs/usage.zh-CN.mdScope
This PR only adds runtime platform domain override support.
It does not change the domain used by Feishu setup/onboarding commands such as:
cc-connect feishu setupcc-connect feishu newcc-connect feishu bindThose flows still use the existing built-in onboarding URLs.
Why
Current
mainalready has internal runtime support for a Feishu/Lark domain concept:lark.WithOpenBaseUrl(...)larkws.WithDomain(...)But this capability was not exposed through config, so users could not actually use it.
This PR exposes that existing runtime capability in a minimal and backward-compatible way.
Validation
gofmt -w platform/feishu/feishu.go platform/feishu/platform_test.gogo test ./platform/feishu -vpnpm install --frozen-lockfile && pnpm buildinweb/go build ./...go test ./...