Skip to content

feat(feishu): support runtime domain override#404

Merged
chenhg5 merged 1 commit intochenhg5:mainfrom
xukp20:feat/feishu-custom-domain
Apr 2, 2026
Merged

feat(feishu): support runtime domain override#404
chenhg5 merged 1 commit intochenhg5:mainfrom
xukp20:feat/feishu-custom-domain

Conversation

@xukp20
Copy link
Copy Markdown
Contributor

@xukp20 xukp20 commented Apr 1, 2026

Summary

Add optional runtime domain override support for Feishu/Lark platform configuration.

Related to #402.

What changed

  • allow projects.platforms.options.domain for feishu / lark
  • use the custom domain for Feishu/Lark runtime SDK clients
  • validate custom domain format during platform initialization
  • keep default behavior unchanged when domain is not set
  • document the new option in:
    • config.example.toml
    • docs/feishu.md
    • docs/usage.md
    • docs/usage.zh-CN.md
  • add regression tests for:
    • custom domain override
    • invalid custom domain rejection

Scope

This PR only adds runtime platform domain override support.

It does not change the domain used by Feishu setup/onboarding commands such as:

  • cc-connect feishu setup
  • cc-connect feishu new
  • cc-connect feishu bind

Those flows still use the existing built-in onboarding URLs.

Why

Current main already has internal runtime support for a Feishu/Lark domain concept:

  • REST client can use lark.WithOpenBaseUrl(...)
  • Feishu WebSocket client can use larkws.WithDomain(...)

But this capability was not exposed through config, so users could not actually use it.

This PR exposes that existing runtime capability in a minimal and backward-compatible way.

Validation

  • gofmt -w platform/feishu/feishu.go platform/feishu/platform_test.go
  • go test ./platform/feishu -v
  • pnpm install --frozen-lockfile && pnpm build in web/
  • go build ./...
  • go test ./...

Copy link
Copy Markdown
Owner

@chenhg5 chenhg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean implementation of Feishu domain override.

Review summary:

  • ✅ Backward compatible (optional config)
  • ✅ URL validation included
  • ✅ Documentation updated
  • ✅ Tests added
  • ✅ CI passes

Good feature for enterprise users with custom Feishu domains.

@chenhg5 chenhg5 merged commit 59098aa into chenhg5:main Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants