Skip to content

Commit

Permalink
Merge pull request #445 from chesslablab/issue/437-Fix-the-naming-con…
Browse files Browse the repository at this point in the history
…vention-for-async-sync-commands

Issue/437 fix the naming convention for async sync commands
  • Loading branch information
programarivm authored Jan 12, 2025
2 parents 5e7f6c7 + 025d9ff commit 3c8f7d6
Show file tree
Hide file tree
Showing 62 changed files with 219 additions and 208 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

use Spatie\Async\Pool;

abstract class AbstractAsyncCommand extends AbstractCommand
abstract class AbstractBlockingCommand extends AbstractCommand
{
protected Pool $pool;

public function setPool(Pool $pool): AbstractAsyncCommand
public function setPool(Pool $pool): AbstractBlockingCommand
{
$this->pool = $pool;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Spatie\Async\Task;

abstract class AbstractAsyncTask extends Task
abstract class AbstractBlockingTask extends Task
{
protected array $env;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use ChessServer\Db;

abstract class AbstractDbAsyncTask extends AbstractAsyncTask
abstract class AbstractDbBlockingTask extends AbstractBlockingTask
{
protected Db $db;

Expand Down
7 changes: 7 additions & 0 deletions src/Command/AbstractNonBlockingCommand.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?php

namespace ChessServer\Command;

abstract class AbstractNonBlockingCommand extends AbstractCommand
{
}
7 changes: 0 additions & 7 deletions src/Command/AbstractSyncCommand.php

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Auth\Async;
namespace ChessServer\Command\Auth\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class TotpRefreshCommand extends AbstractAsyncCommand
class TotpRefreshCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<?php

namespace ChessServer\Command\Auth\Async;
namespace ChessServer\Command\Auth\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;
use Firebase\JWT\JWT;
use Firebase\JWT\Key;

class TotpRefreshTask extends AbstractDbAsyncTask
class TotpRefreshTask extends AbstractDbBlockingTask
{
public function run()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Auth\Async;
namespace ChessServer\Command\Auth\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class TotpSignInCommand extends AbstractAsyncCommand
class TotpSignInCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<?php

namespace ChessServer\Command\Auth\Async;
namespace ChessServer\Command\Auth\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;
use Firebase\JWT\JWT;
use OTPHP\InternalClock;
use OTPHP\TOTP;

class TotpSignInTask extends AbstractDbAsyncTask
class TotpSignInTask extends AbstractDbBlockingTask
{
public function run()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Auth\Async;
namespace ChessServer\Command\Auth\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class TotpSignUpCommand extends AbstractAsyncCommand
class TotpSignUpCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<?php

namespace ChessServer\Command\Auth\Async;
namespace ChessServer\Command\Auth\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;
use OTPHP\InternalClock;
use OTPHP\TOTP;

class TotpSignUpTask extends AbstractDbAsyncTask
class TotpSignUpTask extends AbstractDbBlockingTask
{
public function run()
{
Expand Down
6 changes: 3 additions & 3 deletions src/Command/Auth/Cli.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
namespace ChessServer\Command\Auth;

use ChessServer\Command\AbstractCli;
use ChessServer\Command\Auth\Async\TotpRefreshCommand;
use ChessServer\Command\Auth\Async\TotpSignInCommand;
use ChessServer\Command\Auth\Async\TotpSignUpCommand;
use ChessServer\Command\Auth\Blocking\TotpRefreshCommand;
use ChessServer\Command\Auth\Blocking\TotpSignInCommand;
use ChessServer\Command\Auth\Blocking\TotpSignUpCommand;
use Spatie\Async\Pool;

class Cli extends AbstractCli
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Binary\Async;
namespace ChessServer\Command\Binary\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class ImageCommand extends AbstractAsyncCommand
class ImageCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<?php

namespace ChessServer\Command\Binary\Async;
namespace ChessServer\Command\Binary\Blocking;

use Chess\Media\BoardToPng;
use Chess\Variant\Classical\FEN\StrToBoard as ClassicalStrToBoard;
use Chess\Variant\Classical\PGN\AN\Color;
use ChessServer\Command\AbstractAsyncTask;
use ChessServer\Command\AbstractBlockingTask;
use ChessServer\Socket\AbstractSocket;

class ImageTask extends AbstractAsyncTask
class ImageTask extends AbstractBlockingTask
{
public function run()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Command/Binary/Cli.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace ChessServer\Command\Binary;

use ChessServer\Command\AbstractCli;
use ChessServer\Command\Binary\Async\ImageCommand;
use ChessServer\Command\Binary\Blocking\ImageCommand;
use Spatie\Async\Pool;

class Cli extends AbstractCli
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class AnnotationsGameCommand extends AbstractAsyncCommand
class AnnotationsGameCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;

class AnnotationsGameTask extends AbstractDbAsyncTask
class AnnotationsGameTask extends AbstractDbBlockingTask
{
public function run()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class AutocompleteBlackCommand extends AbstractAsyncCommand
class AutocompleteBlackCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;

class AutocompleteBlackTask extends AbstractDbAsyncTask
class AutocompleteBlackTask extends AbstractDbBlockingTask
{
public function run()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class AutocompleteEventCommand extends AbstractAsyncCommand
class AutocompleteEventCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;

class AutocompleteEventTask extends AbstractDbAsyncTask
class AutocompleteEventTask extends AbstractDbBlockingTask
{
public function run()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class AutocompleteWhiteCommand extends AbstractAsyncCommand
class AutocompleteWhiteCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;

class AutocompleteWhiteTask extends AbstractDbAsyncTask
class AutocompleteWhiteTask extends AbstractDbBlockingTask
{
public function run()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class OpeningCommand extends AbstractAsyncCommand
class OpeningCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;

class OpeningTask extends AbstractDbAsyncTask
class OpeningTask extends AbstractDbBlockingTask
{
const SQL_LIKE = [

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class RankingCommand extends AbstractAsyncCommand
class RankingCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractDbAsyncTask;
use ChessServer\Command\AbstractDbBlockingTask;

class RankingTask extends AbstractDbAsyncTask
class RankingTask extends AbstractDbBlockingTask
{
public function run()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php

namespace ChessServer\Command\Data\Async;
namespace ChessServer\Command\Data\Blocking;

use ChessServer\Command\AbstractAsyncCommand;
use ChessServer\Command\AbstractBlockingCommand;
use ChessServer\Socket\AbstractSocket;

class SearchCommand extends AbstractAsyncCommand
class SearchCommand extends AbstractBlockingCommand
{
public function __construct()
{
Expand Down
Loading

0 comments on commit 3c8f7d6

Please sign in to comment.