Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored History management #31

Merged
merged 13 commits into from
Dec 15, 2022
Merged

Conversation

edoardocavazza
Copy link
Member

Introducing a Path object for hashbang based navigation and a more consistent history management.

@edoardocavazza edoardocavazza added the enhancement New feature or request label Dec 13, 2022
@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

🦋 Changeset detected

Latest commit: 6fac79e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chialab/synapse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Base: 81.90% // Head: 85.86% // Increases project coverage by +3.96% 🎉

Coverage data is based on head (6fac79e) compared to base (0fe44d4).
Patch coverage: 95.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   81.90%   85.86%   +3.96%     
==========================================
  Files          18       22       +4     
  Lines        2343     2554     +211     
  Branches      127      149      +22     
==========================================
+ Hits         1919     2193     +274     
+ Misses        423      360      -63     
  Partials        1        1              
Impacted Files Coverage Δ
src/Helpers/Emitter.ts 81.53% <81.53%> (ø)
src/App.tsx 78.65% <88.23%> (+0.06%) ⬆️
src/Router/Router.ts 90.49% <92.03%> (+0.40%) ⬆️
src/Router/BrowserHistory.ts 97.19% <97.19%> (ø)
src/Helpers/Animations.ts 92.59% <100.00%> (ø)
src/Helpers/App.ts 100.00% <100.00%> (ø)
src/Helpers/Network.ts 73.91% <100.00%> (ø)
src/Helpers/Scripts.ts 93.93% <100.00%> (+51.51%) ⬆️
src/Helpers/StyleSheets.ts 89.09% <100.00%> (+52.72%) ⬆️
src/Router/ErrorHandler.tsx 63.63% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edoardocavazza edoardocavazza changed the title Path object Refactored History management Dec 15, 2022
@edoardocavazza edoardocavazza merged commit 8038357 into main Dec 15, 2022
@edoardocavazza edoardocavazza deleted the refactor-path-constructor branch December 15, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants