Modify Customflatpages #599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flat Pages should allow for specifiying custom images chicagopython#358 Modified the customflat pages to allow people to select the headers they wanted to use.
|
@HugoSeguin this looks really good. I would like to see a test for the view. The test could just check that the image url shows up and verify the flatpage content is rendered. I'm not sure that the profiles app is the right spot for this code. Generally that's for user profile information. I think we should have a flatpages app to keep this code organized. Maybe these items are a follow on ticket though. I'll do a more thorough review tomorrow as it's getting late. Nice job with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flat Pages should allow for specifiying custom images #358
Modified the customflat pages to allow people to select the headers they wanted to use.
Should this be split into 5 separate commits?