Skip to content

Conversation

@BelinChung
Copy link

You will get an error if cm is not initialized.
cm.off() is not a function

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can such a case arise? Also destroy shouldn't have a check on cm. Instead the cm.off statement should be checked for cm inside the destroy function so that rest of the destroy proceeds as usual.

@BelinChung
Copy link
Author

I'm doing a hidden feature, it will be trigger by some specified words.
when I initialize CodeMirror, BlastCode will initialize together. At this time, blastCode option will get a null value, so if you enter destroy function, cm.off() is not a function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants