Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring, cleanup and linting #66

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactoring, cleanup and linting #66

wants to merge 4 commits into from

Conversation

merydian
Copy link
Collaborator

Classes are moved to dedicated files to make the code base more easy to navigate. Unused files are deleted. The preset data is moved to a dedicated json file. The formatter and linter Ruff is applied to the code base to make it more readable.

This is a prerequisit for #14 and is related to #15.

@merydian merydian requested a review from cholmes February 10, 2025 13:10
@merydian merydian self-assigned this Feb 10, 2025
@merydian merydian marked this pull request as draft February 10, 2025 13:18
@merydian
Copy link
Collaborator Author

One question about SUPPORTED_FORMATS, what is this intended for? I could not find any usages of the variable but left it for now in its own json file.

@merydian merydian marked this pull request as ready for review February 10, 2025 14:04
@cholmes
Copy link
Owner

cholmes commented Feb 10, 2025

Thanks a ton for this, don't have time for extensive review, but it's looking good.

I think we'll try to land #65 first, and then this will likely need a bit of an update.

One question about SUPPORTED_FORMATS, what is this intended for? I could not find any usages of the variable but left it for now in its own json file.

@GISAM - I think you probably added this? Or at least I don't remember adding it and it has flatgeobuf / geojson in it. It doesn't seem to be used at all, should we keep it? Or just remove it as part of the clean up / refactoring?

@GISAM
Copy link
Collaborator

GISAM commented Feb 10, 2025

@merydian Ah, good catch! I originally planned to store the formats in the SUPPORTED_FORMATS dictionary so they could be used throughout the codebase, but I never got around to it. Instead, the format options ended up being hardcoded. It can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants