Open
Conversation
choosehappy
reviewed
May 6, 2020
choosehappy
reviewed
May 6, 2020
choosehappy
reviewed
May 6, 2020
choosehappy
requested changes
May 6, 2020
Owner
choosehappy
left a comment
choosehappy
left a comment
There was a problem hiding this comment.
a few minor house keeping issues in the code
one important component missing...you never mention how/where/what these xml files look like. how are they generated? you can add a lot of this information in as a comment at the top of the module
can you also create a directory called "AnnotationModule", you can move your config file in there, and provide a full example of an xml file in there. i think that should nicely cover documentation needs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.