Skip to content

feat: add three new DynamicDark directives to syntax highlighting#132

Merged
chouzz merged 1 commit into
chouzz:mainfrom
pcbogota:fix/syntax-highlighting-for-dynamicdark
Apr 7, 2026
Merged

feat: add three new DynamicDark directives to syntax highlighting#132
chouzz merged 1 commit into
chouzz:mainfrom
pcbogota:fix/syntax-highlighting-for-dynamicdark

Conversation

@pcbogota
Copy link
Copy Markdown
Contributor

@pcbogota pcbogota commented Apr 6, 2026

Summary

This PR improves the syntax highlighting for Inno Setup 6.6+ by adding three missing directives and standardizing the keyword list.

Changes

  1. Added missing directives:
    • WizardImageFileDynamicDark
    • WizardSmallImageFileDynamicDark
    • WizardImageBackColorDynamicDark
  2. Alphabetized the entire list of directives within the match string.
    • This fixes duplicate entries (WizardImageFile and WizardSmallImageFile appeared twice) and makes the file easier to maintain for future contributions.

Testing

I have tested this modification locally with a variety of .iss scripts, and all new and existing directives are now highlighted correctly without any errors.

Why combine both changes in one PR?

While I understand this is a larger change, sorting the list was the natural next step after adding the new keywords to their correct alphabetical positions. I believe a single, clean, and well-organized list is better for the project's long-term maintainability than simply appending the new words to the end.

@chouzz chouzz merged commit e04e3d4 into chouzz:main Apr 7, 2026
2 checks passed
@chouzz
Copy link
Copy Markdown
Owner

chouzz commented Apr 7, 2026

@pcbogota Thanks.

@pcbogota pcbogota deleted the fix/syntax-highlighting-for-dynamicdark branch April 10, 2026 15:14
chouzz added a commit that referenced this pull request Apr 10, 2026
## Summary

Bump version from 1.10.0 to 1.11.0 and update CHANGELOG.md.

## Changes

- Update package.json version to 1.11.0
- Update package-lock.json version to 1.11.0
- Add v1.11.0 changelog entry for DynamicDark directives support

## Changelog

- Add three new DynamicDark directives to syntax highlighting (#132)

Co-authored-by: chouzz <zhouhua259@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants