Proper use of encoding for hashing international characters.#7
Open
michaellopez wants to merge 1 commit into
Open
Proper use of encoding for hashing international characters.#7michaellopez wants to merge 1 commit into
michaellopez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for hash.update() states that if no encoding is given, the argument is expected to be a Buffer.
Like many other "hash tasks" for Grunt, grunt-ver provides the contents of the file as a string to
hash.updatewithout any encoding as a second argument, which is incorrect.The result of this is an incorrect hash for files with international characters in them when no encoding is given to
hash.update.Setting the proper encoding when calling
hash.updatefixes this.PS. This plugin could use a bit of refactoring to allow passing options and such. My PR only handles the encoding bit though.