Skip to content

[ENH] A tool to inspect the number of records on the log. #4934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Jun 24, 2025

Description of changes

I added a gauge that floats the number of collections uncompacted and
extended the inspect-log-state route to have return the start/limit and
number of records on the log.

Test plan

CI

Documentation Changes

Will update runbooks.

rescrv added 6 commits June 24, 2025 11:28
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv requested a review from eculver June 24, 2025 23:53
Copy link
Contributor

This PR extends the log inspection tooling and API by enriching the InspectLogStateResponse with start and limit fields, enabling direct calculation and reporting of the number of records in a log. The CLI tool chroma-inspect-log-state now displays these additional fields and the record count, while the Rust log service and proto definition are updated accordingly.

This summary was automatically generated by @propel-code-bot

@rescrv rescrv requested a review from sanketkedia June 24, 2025 23:54
@rescrv rescrv force-pushed the rescrv/roll-dirty-log branch 3 times, most recently from 8695b78 to 4306673 Compare June 25, 2025 17:14
Base automatically changed from rescrv/roll-dirty-log to main June 25, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant