Skip to content

removed xmlns - #16

Closed
orrybaram wants to merge 1 commit into
chromakode:masterfrom
micnews:master
Closed

orrybaram wants to merge 1 commit into
chromakode:masterfrom
micnews:master

Conversation

@orrybaram

Copy link
Copy Markdown

Hey, we use your lib at mic.com to help make generating emails painless. Thanks for your work!
Unfortunately the lib breaks with react 15.3.0 because of this PR react/react#6471

This is a hotfix for it, not sure if you know of a better way to deal with this.

Error

Invariant Violation: injectDOMPropertyConfig(...): You're trying to inject DOM property 'xmlns' which has already been injected. You may be accidentally injecting the same DOM property config twice, or you may be injecting two configs that have conflicting property names.
    at invariant (/Users/orrybaram/mic/cms/node_modules/fbjs/lib/invariant.js:38:15)
    at Object.DOMPropertyInjection.injectDOMPropertyConfig (/Users/orrybaram/mic/cms/node_modules/react/lib/DOMProperty.js:74:99)
    at injectReactEmailAttributes (/Users/orrybaram/mic/cms/node_modules/react-html-email/lib/injectReactEmailAttributes.js:29:31)

@chromakode

Copy link
Copy Markdown
Owner

Thanks! I added some compatibility hacks and released v1.1.2 on npm. 👍

@chromakode chromakode closed this Aug 8, 2016
@orrybaram

Copy link
Copy Markdown
Author

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants