Part spec additions#1
Conversation
…te fields to part spec. softwareVersion, firmwareVersion are present only in part types that utilize software and/or firmware. These fields are optional.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
| @@ -0,0 +1,2 @@ | |||
| *.code-workspace | |||
| Platform/ADL/ADL-P/Softstrap/Native/*.* | |||
There was a problem hiding this comment.
Not sure if you want this in the .gitignore. We shouldn't run into this and it feels like the wrong type of information for this repo.
|
Yes, you’re right. Will correct when I get a sec.
-Randy
From: rsnancollas <notifications@github.com>
Sent: Tuesday, November 3, 2020 4:49 PM
To: chromeos/digital-datasheets <digital-datasheets@noreply.github.com>
Cc: Hall, Randy E <randy.e.hall@intel.com>; Author <author@noreply.github.com>
Subject: Re: [chromeos/digital-datasheets] Part spec additions (#1)
@rsnancollas commented on this pull request.
________________________________
In .gitignore<#1 (comment)>:
@@ -0,0 +1,2 @@
+*.code-workspace
+Platform/ADL/ADL-P/Softstrap/Native/*.*
Not sure if you want this in the .gitignore. We shouldn't run into this and it feels like the wrong type of information for this repo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJW4J4FB2G2Z7ITZBOIZ4XDSOCQJHANCNFSM4TH7Z3ZA>.
|
|
I wondered about that. We should remove then. Wasn’t sure if you had a “vendor” for that.
-Randy
From: rsnancollas <notifications@github.com>
Sent: Tuesday, November 3, 2020 4:54 PM
To: chromeos/digital-datasheets <digital-datasheets@noreply.github.com>
Cc: Hall, Randy E <randy.e.hall@intel.com>; Author <author@noreply.github.com>
Subject: Re: [chromeos/digital-datasheets] Part spec additions (#1)
@rsnancollas commented on this pull request.
________________________________
In part-spec/part_spec.md<#1 (comment)>:
@@ -773,6 +950,23 @@
* optional
## test point
+* manufacturer
I don't think we'd have these fields for a test point. We can also decide to just remove this from the part spec since it isn't really a part.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJW4J4FPV4TFGPPXEQSW5ITSOCQ3JANCNFSM4TH7Z3ZA>.
|
rsnancollas
left a comment
There was a problem hiding this comment.
Looks good - I've added a few more fields that we can discuss. Also, we might want eolDate for everything, but we can add that in the script.
| * unique URI that can be dereferenced for additional information (driver, firmware, specs, documentation). Follows IETF RFC 3896 | ||
| * type: string | ||
| * optional | ||
| * softwareVersion |
There was a problem hiding this comment.
I don't think a clock would typically have software. Maybe firmware?
| * unique URI that can be dereferenced for additional information (driver, firmware, specs, documentation). Follows IETF RFC 3896 | ||
| * type: string | ||
| * optional | ||
| * softwareVersion |
There was a problem hiding this comment.
not sure about softwareVersion here
Added datasheet version, SW version, FW Version, referenceURI (for datasheet reference, eolDate.