-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add reply functionality to chatroom and update HTTP client for … #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello, and thank you for this! Is there a specific reason you opted for If not, I'd like you to move to using |
in my opinion Message was just a representation class of the message from ws and Chatroom otherwise was a class who handle api communication, thats why i choose Chatroom but if you disagree i could move it to Message |
|
agree i'll come later with fixes |
…ate `send_message` parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all of the work that you've put into this PR.
This will have to stay in limbo for a couple of days until I get a chance to test the code and properly review it from a code editor. When that happens, I'm perfectly fine with fixing the rest of the nitpicky things myself, as there have been a lot of requested changes with this PR so far.
Refactor message handling and add ReplyMetaData extraction
reply_metadata
function to extractReplyMetaData
from aMessage
.kick/types/message.py
to ensure consistency.MessagePayload
type.wss://ws-us2.pusher.com/app/32cbd69e4b950bf97679?protocol=7&client=js&version=8.4.0-rc2&flash=false
…V2 API
This commit ensures that reply messages can be properly handled and their metadata extracted for further processing.