bpf2go: enable ebpf code reuse across go packages #1625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change to listing packages explicitly on command line with Prior iteration (#1509) pulled them from the "magic" |
New -import command line option specifies golang packages to pull headers from. Scan packages for header files, and expose headers to clang. C code consumes headers by providing a go package path in include directive, e.g. frob.c: #include "example.org/foo/foo.h" It is handy for sharing code between multiple ebpf blobs within a project. Even better, it enables sharing ebpf code between multiple projects using go modules as delivery vehicle. "Build" dependencies are recorded in generated files so that "go mod tidy" can see them. Further, we don't check if -import refers to internal packages, but "go build" will. Signed-off-by: Nick Zavaritsky <[email protected]>
mejedi
force-pushed
the
bpf2go-ebpf-code-reuse-v3
branch
from
bda6995 to
4d85998
Compare
|
I don't think we want bpf2go to do C dependency management using Go packages as a vehicle. It's a great idea, but again not something the majority of users will need to leverage. This kind of stuff is also bound to be specific to the the user's code/package layout, so I don't see this translate to the masses. Personally, I'd write a separate tool that can pull C headers from Go packages and roll it into a vfs artifact. (which is basically a tar) Then, call it using a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New -import command line option specifies golang packages to pull headers from. Scan packages for header files, and expose headers to clang. C code consumes headers by providing a go package path in include directive, e.g.
frob.c:
#include "example.org/foo/foo.h"
It is handy for sharing code between multiple ebpf blobs within a project. Even better, it enables sharing ebpf code between multiple projects using go modules as delivery vehicle.
"Build" dependencies are recorded in generated files so that "go mod tidy" can see them. Further, we don't check if -import refers to internal packages, but "go build" will.